fix: openstack needs to use neutron for floating ip association #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackboxsw
force-pushed
the
fix-openstack-to-use-neutron-not-nova-for-ips
branch
2 times, most recently
from
b0340ea to
0fec0ae
Compare
Unit test added to allow coverage of conneonts.network.update_ip and ports calls. It's all mocks anyway, but at least provides a bit of coverage about expected return values from those SDK calls. |
blackboxsw
force-pushed
the
fix-openstack-to-use-neutron-not-nova-for-ips
branch
3 times, most recently
from
a30cbe1 to
e345e4f
Compare
Nova api microversion 2.44 doesn't support associating floating IPs via to compute API endpoint anymore. Associating floating IPs to servers must be done via the neutron(network) API endpoints instead to avoid 404s during floating IP association to servers using the nova(compute) endoint. Add an example/ostack.py basic lifecycle script to ease local testing of openstack instance lifecycle.
|
Dropped py38 from CI as ubuntu-20-04 environments are no longer supported in github workflows |
|
at least 2 approving reviews??? What is this madness?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nova api microversion 2.44 doesn't support associating floating IPs via to compute API endpoint anymore.
Associating floating IPs to servers must be done via the neutron(network) API endpoints instead to avoid 404s during floating IP association to servers using the nova(compute) endoint.
Add an example/ostack.py basic lifecycle script to ease local testing of openstack instance lifecycle.
PR Checklist
To ease the process of reviewing your PR, do make sure to complete the following checklist before submitting a pull
request
tox -e formatlocally to automatically format my code before submittingtoxlocally ensuring that it passes before submittingOtherwise, please leave the PR as a draft to indicate that it is still a work in progress.
-->
Additional Context and Relevant Issues
Upstream docs stating deprecated behavior for floating IPs in nova/compute
https://docs.openstack.org/api-ref/compute/#add-associate-floating-ip-addfloatingip-action-deprecated
Test Steps